Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33343 )
Change subject: atavia.c: Remove unneeded 'else' ......................................................................
Patch Set 1:
(1 comment)
Indeed, it is more "conformable" to have the 'else' branch here.
What I'm concerned about is if we can argue that the code *is generally better* with the else removed (that `continue` aside) and make that a rule. Without a rule, somebody could just push another patch that adds the else back...
In other words, "what does this fix?".
Actually, I agree to the removal of `else` in all three patches. But without a rule...
Is there any compiler warning, or how did you spot these?
https://review.coreboot.org/#/c/33343/1/atavia.c File atavia.c:
https://review.coreboot.org/#/c/33343/1/atavia.c@107 PS1, Line 107: continue;
for my understanding, there is no difference between old and new code.
That's right. But an `continue` at the end of a loop body is obviously a no-op.