Indeed, it is more "conformable" to have the 'else' branch here.

What I'm concerned about is if we can argue that the code *is
generally better* with the else removed (that `continue` aside)
and make that a rule. Without a rule, somebody could just push
another patch that adds the else back...

In other words, "what does this fix?".

Actually, I agree to the removal of `else` in all three patches.
But without a rule...

Is there any compiler warning, or how did you spot these?

View Change

1 comment:

• File atavia.c:

  • Patch Set #1, Line 107: continue;

    for my understanding, there is no difference between old and new code.

    That's right. But an `continue` at the end of a loop body is
    obviously a no-op.

To view, visit change 33343. To unsubscribe, or for help writing mail filters, visit settings.