Attention is currently required from: Angel Pons, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70128 )
Change subject: flashrom: Skip read/write/erase/verify ops on inaccessable flash regions ......................................................................
Patch Set 14:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/70128/comment/e60b6e4f_2fdb4cfa PS13, Line 348: region->name = strdup("");
I mean, set to `NULL` in this function and at the call sites of `get_flash_region()` just have; `con […]
Oh I see the `strdup()` now in the previous patch to which you are referring to. OK, just insert the `free()`'s. The problem will go away upon the second iteration of this when the fixture is within the layout life-time. This `strdup()` thing is relatively minor in the grand scheme of things, avoid fixating on it in favor of realising the layout integration goal.