Attention is currently required from: Angel Pons, Nikolai Artemiev.
View Change
1 comment:
File flashrom.c:
Patch Set #13, Line 348: region->name = strdup("");
I mean, set to `NULL` in this function and at the call sites of `get_flash_region()` just have; `con […]
Oh I see the `strdup()` now in the previous patch to which you are referring to. OK, just insert the `free()`'s. The problem will go away upon the second iteration of this when the fixture is within the layout life-time. This `strdup()` thing is relatively minor in the grand scheme of things, avoid fixating on it in favor of realising the layout integration goal.
To view, visit change 70128. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9b96fb04b863625d2c9f9a00b97c35b3ddb0871b
Gerrit-Change-Number: 70128
Gerrit-PatchSet: 14
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Wed, 07 Dec 2022 05:36:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com>
Gerrit-MessageType: comment