Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )
Change subject: flashchips.c: Replace comment with #if 0 ......................................................................
Patch Set 7:
Patch Set 7:
Patch Set 7:
Not sure if this entry should just be removed.
I agree, it should either be finished (i.e. add erasers and voltage range) or just dropped. The comment could be moved to AT25DF321 in the latter case.
If the datasheet is available, I would prefer to make it whole entry.
Looks like the datasheet exists: https://cdn.hackaday.io/files/7758331918272/AT26DF321.pdf
It looks as though the AT26DF321 is marked obsolete by Digikey and not really mentioned on Atmel's site. Since we've done without a working definition for this long, I'll just remove it for now and move the comment about same ID to the AT25DF321 entry.