[flashrom-gerrit] [S] Change in flashrom[master]: flashrom.c: Embed is_internal state within the flashctx

[Angel Pons (Code Review)]

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67476 )

Change subject: flashrom.c: Embed is_internal state within the flashctx
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/67476/comment/4a9563b0_2da05ddc 
PS2, Line 1007: fill_flash->is_internal = prog->is_internal;
> self check Q: what about libflashrom

What if, for now, we keep the `is_internal_programmer()` function to initialize the flashctx parameter? It seems like a reasonable intermediate step.

Think of it like the time we split CB:66659 into CB:67094 and CB:67649 for other reasons.