Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Patch set 3:Code-Review +1
View Change
1 comment:
File cli_classic.c:
Patch Set #2, Line 1007: fill_flash->is_internal = prog->is_internal;
self check Q: what about libflashrom
What if, for now, we keep the `is_internal_programmer()` function to initialize the flashctx parameter? It seems like a reasonable intermediate step.
Think of it like the time we split CB:66659 into CB:67094 and CB:67649 for other reasons.
To view, visit change 67476. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I25717afc3a8f61ca9f4dfb4bb60d6cb048a2ad37
Gerrit-Change-Number: 67476
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Mon, 10 Oct 2022 11:28:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment