Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51706 )
Change subject: dediprog.c: Split up compound conditional statement ......................................................................
Patch Set 1:
(1 comment)
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/51706/comment/2668b417_49bbe04a PS1, Line 1276: if (register_spi_master(&spi_master_dediprog)) : return 1; : : return dediprog_set_leds(LED_NONE);
I think register_spi_master can be the very last line, means we register something only after all in […]
I've preserved the original behaviour of the code, just moved the `dediprog_set_leds` call out of the if-statement.
In any case, if setting the LEDs fails, then something is very wrong with the programmer, and returning an error is justified.