Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.

View Change

1 comment:

• File dediprog.c:

  • Patch Set #1, Line 1276:

    	if (register_spi_master(&spi_master_dediprog))
    		return 1;
    
    	return dediprog_set_leds(LED_NONE);
    

    I think register_spi_master can be the very last line, means we register something only after all in […]

    I've preserved the original behaviour of the code, just moved the `dediprog_set_leds` call out of the if-statement.

    In any case, if setting the LEDs fails, then something is very wrong with the programmer, and returning an error is justified.

To view, visit change 51706. To unsubscribe, or for help writing mail filters, visit settings.