Attention is currently required from: David Hendricks, Edward O'Callaghan, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31012 )
Change subject: cli_classic: Report the gathered layout entries at level dbg ......................................................................
Patch Set 4:
(3 comments)
File layout.c:
https://review.coreboot.org/c/flashrom/+/31012/comment/046e0185_3cd78f5c PS3, Line 436: l->num_entries
Done, thoughts?
I probably only put the number there because it was part of the struct. The important part was to have some feedback about possible arguments to `-i`.
Doesn't hurt to print it anyway, though ;)
File layout.c:
https://review.coreboot.org/c/flashrom/+/31012/comment/e27b495b_e31cc780 PS4, Line 436: for (struct romentry *entry = l->head; entry; entry = entry->next) { Please use `layout_next()`.
https://review.coreboot.org/c/flashrom/+/31012/comment/4a9a29ee_835d73f4 PS4, Line 441: msg_gdbg("Total %u entries\n", i); It feels like we might want a period at the end. I know it's not a complete sentence anyway.