Attention is currently required from: David Hendricks, Edward O'Callaghan, Angel Pons.

View Change

3 comments:

• File layout.c:

  • Patch Set #3, Line 436: l->num_entries

    Done, thoughts?

    I probably only put the number there because it was part of the struct. The
    important part was to have some feedback about possible arguments to `-i`.

    Doesn't hurt to print it anyway, though ;)

• File layout.c:

  • Patch Set #4, Line 436: for (struct romentry *entry = l->head; entry; entry = entry->next) {

    Please use `layout_next()`.

  • Patch Set #4, Line 441: msg_gdbg("Total %u entries\n", i);

    It feels like we might want a period at the end. I know it's not a complete
    sentence anyway.

To view, visit change 31012. To unsubscribe, or for help writing mail filters, visit settings.