Attention is currently required from: Nico Huber, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54890 )
Change subject: programmer: Introduce default shutdown function ......................................................................
Patch Set 5: Code-Review+1
(5 comments)
Patchset:
PS5:
Personally, I don't mind adding something that ends up being removed later, as long as it provides s […]
Agreed but I think a small [optional] variation as suggested inline puts the code slightly more inline with the future?
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/54890/comment/149aca10_67fea22b PS5, Line 78: int default_shutdown(void *data) `static int default_shutdown(void *data)`
https://review.coreboot.org/c/flashrom/+/54890/comment/687b7dc1_ab3dd9b4 PS5, Line 104: function; `shutdown_fn[shutdown_fn_count].func = !function ? default_shutdown : function;`
File mcp6x_spi.c:
https://review.coreboot.org/c/flashrom/+/54890/comment/30eab7fa_84811336 PS5, Line 177: default_shutdown just pass `NULL`
File programmer.h:
https://review.coreboot.org/c/flashrom/+/54890/comment/e6ce0cdd_efbd200e PS5, Line 337: int default_shutdown(void *data); no need.