Attention is currently required from: Nico Huber, Anastasia Klimchuk.

Patch set 5:Code-Review +1

View Change

5 comments:

• Patchset:

  • Patch Set #5:

    Personally, I don't mind adding something that ends up being removed later, as long as it provides s […]

    Agreed but I think a small [optional] variation as suggested inline puts the code slightly more inline with the future?

• File flashrom.c:

  • Patch Set #5, Line 78: int default_shutdown(void *data)

    `static int default_shutdown(void *data)`

  • Patch Set #5, Line 104: function;

    `shutdown_fn[shutdown_fn_count].func = !function ? default_shutdown : function;`

• File mcp6x_spi.c:

  • Patch Set #5, Line 177: default_shutdown

    just pass `NULL`

• File programmer.h:

  • Patch Set #5, Line 337: int default_shutdown(void *data);

    no need.

To view, visit change 54890. To unsubscribe, or for help writing mail filters, visit settings.