Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Add support for USB SPI protocol V2 ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c@726 PS2, Line 726:
I'm using spaces to align these multi-line function calls, especially the ones with mutli-line strin […]
Ack
https://review.coreboot.org/c/flashrom/+/41533/12/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/12/raiden_debug_spi.c@1154 PS12, Line 1154: write_attempt = 0
I'd prefer to keep the initialization inside the loop head, but keep the declaration here: […]
Done
https://review.coreboot.org/c/flashrom/+/41533/12/raiden_debug_spi.c@1212 PS12, Line 1212: for (; read_attempt < READ_RETRY_ATTEMPTS; : read_attempt++) {
Here you definitely want to initialize the variable in the loop head: […]
Done