View Change

3 comments:

• File raiden_debug_spi.c:

  • Patch Set #2, Line 726:

    I'm using spaces to align these multi-line function calls, especially the ones with mutli-line strin […]

    Ack

• File raiden_debug_spi.c:

  • Patch Set #12, Line 1154: write_attempt = 0

    I'd prefer to keep the initialization inside the loop head, but keep the declaration here: […]

    Done

  • Patch Set #12, Line 1212:

    for (; read_attempt < READ_RETRY_ATTEMPTS;
    				read_attempt++) {
    

    Here you definitely want to initialize the variable in the loop head: […]

    Done

To view, visit change 41533. To unsubscribe, or for help writing mail filters, visit settings.