[flashrom-gerrit] Change in flashrom[master]: Revert "flashchips: port S25FS(128S) chip from chromiumos"

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40626 )

Change subject: Revert "flashchips: port S25FS(128S) chip from chromiumos"
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/flashrom/+/40626/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/40626/1//COMMIT_MSG@11 
PS1, Line 11: most
> What broke for you Nico? A local test for me didn't break on a Intel platform

I was able to locally reproduce the failure with a Winbond, Thanks for picking this up quickly!

It was reviewed it, just wasn't noticed due to the similar function names/files [`s25f_poll_status():s25f.c` / `spi_poll_wip():spi25.c`] and the specific chip I tested with locally.

I agree with the big and invasive comment though, I put too much trust in the commit message explanation for that.