View Change
1 comment:
Commit Message:
Patch Set #1, Line 11: most
What broke for you Nico? A local test for me didn't break on a Intel platform
I was able to locally reproduce the failure with a Winbond, Thanks for picking this up quickly!
It was reviewed it, just wasn't noticed due to the similar function names/files [`s25f_poll_status():s25f.c` / `spi_poll_wip():spi25.c`] and the specific chip I tested with locally.
I agree with the big and invasive comment though, I put too much trust in the commit message explanation for that.
To view, visit change 40626. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id2a4593bdb654f8a26957d69d52189ce61621d93
Gerrit-Change-Number: 40626
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Samir Ibradžić <sibradzic@gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 28 Apr 2020 01:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment