Namyoon Woo has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44879 )
Change subject: support variable-size SPI chip for dummy programmer
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/44879/1/dummyflasher.c
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/44879/1/dummyflasher.c@395
PS1, Line 395: if (!strncmp(tmp, VARIABLE_SIZE_CHIP_NAME,
: strlen(VARIABLE_SIZE_CHIP_NAME))) {
I think this is fine to put on the same line for readability.
Like other cases above, I converted it to use strcmp(), without a name definition.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/44879
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iff266e151459561b126ecfd1c47420b385be1db2
Gerrit-Change-Number: 44879
Gerrit-PatchSet: 2
Gerrit-Owner: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Aug 2020 23:59:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment