[flashrom-gerrit] [M] Change in flashrom[master]: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently

[Felix Singer (Code Review)]

Attention is currently required from: Nico Huber, Subrata Banik, Thomas Heijligen, Edward O'Callaghan.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64968 )

Change subject: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently
......................................................................

Patch Set 6:

(1 comment)

Commit Message:

https://review.coreboot.org/c/flashrom/+/64968/comment/bd23fd36_255b6d73 
PS6, Line 7: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently
> Same, but the point here is that future work is a lot easier with consistent code not half complete  […]

Right, but why don't we move everything to the functions? The macros only remove the need to specify ichspi_bar, but as soon as ichspi_bar is turned into a local variable we will have to add another argument to the macros for it and so there is no advantage of the macros anymore, if any.