Attention is currently required from: Nico Huber, Subrata Banik, Thomas Heijligen, Edward O'Callaghan.
View Change
1 comment:
Commit Message:
Patch Set #6, Line 7: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently
Same, but the point here is that future work is a lot easier with consistent code not half complete […]
Right, but why don't we move everything to the functions? The macros only remove the need to specify ichspi_bar, but as soon as ichspi_bar is turned into a local variable we will have to add another argument to the macros for it and so there is no advantage of the macros anymore, if any.
To view, visit change 64968. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8c90ea1ff617a451a671827d7bc49679d349c79d
Gerrit-Change-Number: 64968
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Fri, 23 Sep 2022 13:07:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment