Attention is currently required from: Harsha B R, Ravishankar Sarawadi.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69928 )
Change subject: flashchips: Add support for GigaDevice GD251R512ME ......................................................................
Patch Set 1:
(3 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/69928/comment/45919f7f_721bb079 PS1, Line 7059: .reg_bits = : { : .srp = {STATUS1, 7, RW}, : .srl = {STATUS2, 0, RW}, : .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}}, : .tb = {STATUS1, 5, RW}, /* Called BP3 in datasheet, acts like TB */ : .sec = {STATUS1, 6, RW}, /* Called BP4 in datasheet, acts like SEC */ : .cmp = {STATUS2, 6, RW}, : }, : .decode_range = DECODE_RANGE_SPI25, Add a similar block for the new flash part.
https://review.coreboot.org/c/flashrom/+/69928/comment/328d2e91_73c0894a PS1, Line 7425: spi_prettyprint_status_register_bp3_srwd Use macro instead. refer to other entries.
https://review.coreboot.org/c/flashrom/+/69928/comment/bd64b0a6_49c3ba0a PS1, Line 7426: spi_disable_blockprotect Use macro instead. refer to other entries.