Attention is currently required from: Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72807 )
Change subject: ch341a_spi: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 3:
(2 comments)
File ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/72807/comment/facf031d_250d076f PS3, Line 80: struct libusb_transfer *transfer_out; : struct libusb_transfer *transfer_ins[USB_IN_TRANSFERS]; : : /* Accumulate delays to be plucked between CS deassertion and CS assertions. */ : unsigned int stored_delay_us; : : struct libusb_device_handle *handle;
Will default values for these be the same as before? […]
Yes, they will. Memory in ch341a_spi_data is allocated at the beginning of initialization using `calloc()`, so it will be 0s/NULLs.
https://review.coreboot.org/c/flashrom/+/72807/comment/f419795f_090d8665 PS3, Line 461: msg_pwarn("Cannot detach the existing USB driver. Claiming the interface may fail. %s\n", : libusb_error_name(ret));
Is this an error branch? It should `goto free_data` then. […]
This is warn branch. So, no need to do something