Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58561 )
Change subject: Add -W options from Makefile into meson warning_flags ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
Meson has build-in support for warnings. Maybe it's better to use them. […]
Official doc do not explain what exactly each warning level is doing :\ But I found info here: https://github.com/mesonbuild/meson/issues/3275
Quote: * warning_level 1 adds `-Wall`, -warning_level 2 adds warning_level 1 + `-Wextra`, * warning_level 3 adds warning_level 2 + `-Wpedantic`
Looks like warning_level was actually what we want (corresponding to makefile).
So for this patch, I added two remaining options that were missing in comparison with makefile.
PS2:
Maybe we can combine Werror with the buildtype?
I was thinking to use werror option (it is mentioned here https://mesonbuild.com/Builtin-options.html#core-options) but I wanted to do it in a separate patch. I will try and see how it goes.