[flashrom-gerrit] Change in flashrom[master]: dediprog: Enable 4BA for all protocols

[Patrick Rudolph (Code Review)]

Hello Patrick Rudolph,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/flashrom/+/44776

to review the following change.

Change subject: dediprog: Enable 4BA for all protocols
......................................................................

dediprog: Enable 4BA for all protocols

* Tested on SF600 with protocol version 3 with "W25Q256.W" (32768 kB)
* Tested on SF100 with protocol version 2 with "W25Q256.W" (32768 kB)

As it works with all protocol version, assume that the SF200 works fine
as well.

Change-Id: Iee0ba972245b9317ef86345432fec5fc32614888
Signed-off-by: Patrick Rudolph 
---
M dediprog.c
1 file changed, 1 insertion(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/44776/1

diff --git a/dediprog.c b/dediprog.c
index 827d5e4..13365cd 100644
--- a/dediprog.c
+++ b/dediprog.c
@@ -993,7 +993,7 @@
 }

static struct spi_master spi_master_dediprog = {
-	.features	= SPI_MASTER_NO_4BA_MODES,
+	.features	= SPI_MASTER_4BA,
    .max_data_read	= 16, /* 18 seems to work fine as well, but 19 times out sometimes with FW 5.15. */
    .max_data_write	= 16,
    .command	= dediprog_spi_send_command,
@@ -1268,12 +1268,6 @@
    if (dediprog_standalone_mode())
    	return 1;

-	if (dediprog_devicetype == DEV_SF100 && protocol() == PROTOCOL_V1)
-		spi_master_dediprog.features &= ~SPI_MASTER_NO_4BA_MODES;
-
-	if (protocol() == PROTOCOL_V2)
-		spi_master_dediprog.features |= SPI_MASTER_4BA;
-
    if (register_spi_master(&spi_master_dediprog) || dediprog_set_leds(LED_NONE))
    	return 1;