Attention is currently required from: Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66211 )
Change subject: spi25_statusreg: support reading/writing "configuration registers" ......................................................................
Patch Set 5:
(1 comment)
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/66211/comment/80af1695_d5217c3a PS5, Line 189: /* For chips that call SR2 "Configuration Register 1" */ : #define CONFIG1 STATUS2 : /* For chips that call SR3 "Configuration Register 2" */ : #define CONFIG2 STATUS3 Is it instead a good idea to add these as new values to the `flash_reg` enum and separately switch on those values if there is semantic difference between `STATUSx` and `CONFIGx`? Seems more robust than short-circuiting though the `STATUSx` pattern match and jamming in another branch there.
This keeps the pattern match mapping between register space and opcode as 1:1.