Attention is currently required from: Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

1 comment:

• File include/flash.h:

  • Patch Set #5, Line 189:

    /* For chips that call SR2 "Configuration Register 1" */
    #define CONFIG1 STATUS2
    /* For chips that call SR3 "Configuration Register 2" */
    #define CONFIG2 STATUS3
    

    Is it instead a good idea to add these as new values to the `flash_reg` enum and separately switch on those values if there is semantic difference between `STATUSx` and `CONFIGx`? Seems more robust than short-circuiting though the `STATUSx` pattern match and jamming in another branch there.

    This keeps the pattern match mapping between register space and opcode as 1:1.

To view, visit change 66211. To unsubscribe, or for help writing mail filters, visit settings.