Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30995 )
Change subject: ichspi: Add Apollo Lake support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@348 PS1, Line 348: ME
Maybe name it ROMB on APL? But again, APL-specific naming seems to be not trivial to implement. […]
Somewhere should be a hint that APL differs from other platforms. It must not be here. Maybe on the APL specific string in prettyprint_ich_descriptor_master()
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@452 PS1, Line 452: TXE
That's right, though, does it matter that much here?
This string is APL specific. Here we could say TXE(ROM Bypass) to point out that APL differs form the rest