View Change
2 comments:
File ich_descriptors.c:
Patch Set #1, Line 348: ME
Maybe name it ROMB on APL? But again, APL-specific naming seems to be not trivial to implement. […]
Somewhere should be a hint that APL differs from other platforms. It must not be here. Maybe on the APL specific string in prettyprint_ich_descriptor_master()
Patch Set #1, Line 452: TXE
That's right, though, does it matter that much here?
This string is APL specific. Here we could say TXE(ROM Bypass) to point out that APL differs form the rest
To view, visit change 30995. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c464b5b3d151e6d28d5db96495fe874a0a45718
Gerrit-Change-Number: 30995
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 28 Jan 2019 10:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment