Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57918 )
Change subject: tests: Add init-shutdown test for raiden_debug_spi ......................................................................
Patch Set 6:
(2 comments)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/57918/comment/63ee8046_4faa2e03 PS5, Line 60: **list = calloc(1, sizeof(*list));
I just removed all that, and now it works... […]
I think it's ok. What happens is that you allocate an array (a list) of length 1 of libusb_device pointers. So you have a list containing a single NULL-pointer representing a device. This NULL-pointer gets passed by the library user to libusb_get_device_descriptor() etc. later. As your wraps ignore the `dev` pointer, it doesn't matter that it's NULL.
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/57918/comment/f392f2d2_f1236c17 PS6, Line 57: ss
these are all static symbols and guarded with `CONFIG_RAIDEN_DEBUG_SPI == 1`
Hmmm, usually we have the compiler warn about it (missing-prototype?). Is the Meson setup using different compiler options? I'm starting to wonder if it's much work to switch away from it for the tests.