Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• File tests/init_shutdown.c:

  • Patch Set #5, Line 60: **list = calloc(1, sizeof(*list));

    I just removed all that, and now it works... […]

    I think it's ok. What happens is that you allocate an array (a list) of
    length 1 of libusb_device pointers. So you have a list containing a single
    NULL-pointer representing a device. This NULL-pointer gets passed by the
    library user to libusb_get_device_descriptor() etc. later. As your wraps
    ignore the `dev` pointer, it doesn't matter that it's NULL.

• File tests/init_shutdown.c:

  • Patch Set #6, Line 57: ss

    these are all static symbols and guarded with `CONFIG_RAIDEN_DEBUG_SPI == 1`

    Hmmm, usually we have the compiler warn about it (missing-prototype?).
    Is the Meson setup using different compiler options? I'm starting to
    wonder if it's much work to switch away from it for the tests.

To view, visit change 57918. To unsubscribe, or for help writing mail filters, visit settings.