Attention is currently required from: Daniel Campello. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54147 )
Change subject: libflashrom: clear layout on flashrom_layout_release ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/54147/comment/3c6aae79_221ea60e PS2, Line 10: (as is currently always : the case)
Not --layout
As below, AFAICT you'll always get the global layout unless using IFD. Revised to reflect that.
https://review.coreboot.org/c/flashrom/+/54147/comment/53130542_e57a093c PS2, Line 14: it's always the global layout
how can user do this on libflashrom? I think the global layout is only used by cli_classic
Both flashrom_layout_read_fmap_* functions return a pointer to the global layout, so you'll only not get the global layout if you use IFD (as far as the libflashrom.h API goes).