Attention is currently required from: Daniel Campello.
View Change
2 comments:
Commit Message:
Patch Set #2, Line 10:
(as is currently always
the case)
Not --layout
As below, AFAICT you'll always get the global layout unless using IFD. Revised to reflect that.
Patch Set #2, Line 14: it's always the global layout
how can user do this on libflashrom? I think the global layout is only used by cli_classic
Both flashrom_layout_read_fmap_* functions return a pointer to the global layout, so you'll only not get the global layout if you use IFD (as far as the libflashrom.h API goes).
To view, visit change 54147. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8ba4b356f2a40ccbfd4e91f81af01d5f6a6de515
Gerrit-Change-Number: 54147
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Daniel Campello <campello@chromium.org>
Gerrit-Comment-Date: Thu, 13 May 2021 03:03:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Campello <campello@chromium.org>
Gerrit-MessageType: comment