Attention is currently required from: Mimoja. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37987 )
Change subject: chipset_enable.c: Add Ice Lake U to known and tested systems ......................................................................
Patch Set 8:
TGL IDs in flashrom are LPC/eSPI DIDs. Also, see this comment in `enable_flash_pch100_or_c620`: […]
It's somewhat all true. The missing link is that Intel stopped telling firmware developers to hide the device. So for newer platforms we can use the ID of the SPI PCI device. It's a bit confusing because on these platforms we now find the SPI PCI device, then look it up again as if it was hidden. A patch to untangle that would be welcome (IIRC there are comments on this in the Elkhart Lake review).
I guess for the newer platforms it's reasonably safe to assume that the device is _not_ hidden. Hence we just use the SPI PCI ID. If ever some new machines turn up where it is hidden, we can still add the LPC/eSPI IDs. But once we have added an LPC ID, we can't safely remove it without risking regressions. So I'd just keep that ID for Ice Lake and add the SPI PCI ID for it too.