Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35808 )
Change subject: Fix compilation if CONFIG_INTERNAL=no ......................................................................
Patch Set 1:
(3 comments)
Hi, thanks for this patch.
I left a few comments about a few things I'm not sure of for Nico to check.
https://review.coreboot.org/c/flashrom/+/35808/1/libflashrom.c File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/35808/1/libflashrom.c@171 PS1, Line 171: struct flashrom_board_info *flashrom_supported_boards(void) I think this function as a whole is specific to the internal programmer
https://review.coreboot.org/c/flashrom/+/35808/1/libflashrom.c@207 PS1, Line 207: struct flashrom_chipset_info *flashrom_supported_chipsets(void) Same for this one
https://review.coreboot.org/c/flashrom/+/35808/1/physmap.c File physmap.c:
https://review.coreboot.org/c/flashrom/+/35808/1/physmap.c@366 PS1, Line 366: /* MSR abstraction implementations for Linux, OpenBSD, FreeBSD/Dragonfly, OSX, libpayload : * and a non-working default implementation on the bottom. See also hwaccess.h for some (re)declarations. */ I doubt that anything from here onwards is needed for anything but the internal programmer.