Hi, thanks for this patch.

I left a few comments about a few things I'm not sure of for Nico to check.

View Change

3 comments:

• File libflashrom.c:

  • Patch Set #1, Line 171: struct flashrom_board_info *flashrom_supported_boards(void)

    I think this function as a whole is specific to the internal programmer

  • Patch Set #1, Line 207: struct flashrom_chipset_info *flashrom_supported_chipsets(void)

    Same for this one

• File physmap.c:

  • Patch Set #1, Line 366:

    /* MSR abstraction implementations for Linux, OpenBSD, FreeBSD/Dragonfly, OSX, libpayload
     * and a non-working default implementation on the bottom. See also hwaccess.h for some (re)declarations. */
    

    I doubt that anything from here onwards is needed for anything but the internal programmer.

To view, visit change 35808. To unsubscribe, or for help writing mail filters, visit settings.