Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/32213 )
Change subject: pickit2_spi: update to libusb1 and drop libusb0 dependency ......................................................................
Patch Set 8:
(11 comments)
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c File pickit2_spi.c:
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c@54 PS7, Line 54: #endif
Not used here in this file? Then drop it.
Ack
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c@104 PS7, Line 104: NULL
NULL is only allowed since libusb 1.0.21. Sorry.
Ack
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c@104 PS7, Line 104: (unsigned char *)
This cast shouldn't be needed any more. And many more below...
Ack
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c@366 PS7, Line 366: libusb_strerror
It was only introduced 6 years ago, I guess that is why it's not […]
Ack
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c@373 PS7, Line 373: libusb_close(pickit2_handle);
libusb_exit(NULL);
Ack
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c@428 PS7, Line 428: }
Not a bug, could be a library user opening the device a second […]
Ack
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c@445 PS7, Line 445: msg_perr("Could not open device PICkit2!\n");
libusb_exit(NULL);
Ack
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c@451 PS7, Line 451: libusb_close(pickit2_handle);
libusb_exit(NULL);
Ack
https://review.coreboot.org/c/flashrom/+/32213/7/pickit2_spi.c@456 PS7, Line 456: libusb_close(pickit2_handle);
libusb_exit(NULL);
Ack
https://review.coreboot.org/c/flashrom/+/32213/8/pickit2_spi.c File pickit2_spi.c:
https://review.coreboot.org/c/flashrom/+/32213/8/pickit2_spi.c@476 PS8, Line 476: (unsigned char *) :(
https://review.coreboot.org/c/flashrom/+/32213/8/pickit2_spi.c@476 PS8, Line 476: NULL :(