View Change

11 comments:

• File pickit2_spi.c:

  • Patch Set #7, Line 54: #endif

    Not used here in this file? Then drop it.

    Ack

  • Patch Set #7, Line 104: NULL

    NULL is only allowed since libusb 1.0.21. Sorry.

    Ack

  • Patch Set #7, Line 104: (unsigned char *)

    This cast shouldn't be needed any more. And many more below...

    Ack

  • Patch Set #7, Line 366: libusb_strerror

    It was only introduced 6 years ago, I guess that is why it's not […]

    Ack

  • Patch Set #7, Line 373: libusb_close(pickit2_handle);

    libusb_exit(NULL);

    Ack

  • Patch Set #7, Line 428: }

    Not a bug, could be a library user opening the device a second […]

    Ack

  • Patch Set #7, Line 445: msg_perr("Could not open device PICkit2!\n");

    libusb_exit(NULL);

    Ack

  • Patch Set #7, Line 451: libusb_close(pickit2_handle);

    libusb_exit(NULL);

    Ack

  • Patch Set #7, Line 456: libusb_close(pickit2_handle);

    libusb_exit(NULL);

    Ack

• File pickit2_spi.c:

  • Patch Set #8, Line 476: (unsigned char *)

    :(

  • Patch Set #8, Line 476: NULL

    :(

To view, visit change 32213. To unsubscribe, or for help writing mail filters, visit settings.