[flashrom-gerrit] Change in flashrom[master]: lspcon: restart MPU on programmer shutdown

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Sam McNally, Peter Marheine.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55403 )

Change subject: lspcon: restart MPU on programmer shutdown
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

File lspcon_i2c_spi.c:

https://review.coreboot.org/c/flashrom/+/55403/comment/116eabee_61f5b07b 
PS1, Line 321: static int lspcon_i2c_spi_reset_mpu_stop(int fd)
             : {
             : 	int ret = 0;
             : 	ret |= lspcon_i2c_spi_write_register(fd, MPU, 0xc0); // cmd mode
             : 	ret |= lspcon_i2c_spi_write_register(fd, MPU, 0x40); // stop mcu
             : 
             : 	return ret;
             : }
             : 
             : static int lspcon_i2c_spi_start_mpu(int fd)
             : {
             : 	int ret;
             : 	// Assert reset
             : 	if ((ret = lspcon_i2c_spi_write_register(fd, MPU, 0xc0)) != 0)
             : 		return ret;
             : 	// Release reset and start MPU
             : 	return lspcon_i2c_spi_write_register(fd, MPU, 0);
             : }
             : 
Hey Peter, could just perhaps just combine these two functions as `lspcon_i2c_spi_mcu_state_toggle` ?