Attention is currently required from: Sam McNally, Peter Marheine.

Patch set 1:Code-Review +2

View Change

1 comment:

• File lspcon_i2c_spi.c:

  • Patch Set #1, Line 321:

    static int lspcon_i2c_spi_reset_mpu_stop(int fd)
    {
    	int ret = 0;
    	ret |= lspcon_i2c_spi_write_register(fd, MPU, 0xc0); // cmd mode
    	ret |= lspcon_i2c_spi_write_register(fd, MPU, 0x40); // stop mcu
    
    	return ret;
    }
    
    static int lspcon_i2c_spi_start_mpu(int fd)
    {
    	int ret;
    	// Assert reset
    	if ((ret = lspcon_i2c_spi_write_register(fd, MPU, 0xc0)) != 0)
    		return ret;
    	// Release reset and start MPU
    	return lspcon_i2c_spi_write_register(fd, MPU, 0);
    }
    
    

    Hey Peter, could just perhaps just combine these two functions as `lspcon_i2c_spi_mcu_state_toggle` ?

To view, visit change 55403. To unsubscribe, or for help writing mail filters, visit settings.