Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46325 )
Change subject: ichspi.c: ich7_run_opcode() fail early on transact error ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/flashrom/+/46325/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46325/1//COMMIT_MSG@7 PS1, Line 7: ich7_run_opcode() fail early on transact error Bail early on flash cycle errors in ich7_run_opcode()
https://review.coreboot.org/c/flashrom/+/46325/1//COMMIT_MSG@9 PS1, Line 9: This patch is adapted from the ChromiumOS fork. While we no longer ship : and support the devices: nit: IMHO, the last sentence parses a bit strange. I'd say:
This patch is adapted from the ChromiumOS fork, and was used on the following, now-obsolete devices:
https://review.coreboot.org/c/flashrom/+/46325/1//COMMIT_MSG@12 PS1, Line 12: , I'd omit the punctuation on the elements of this list