Patch set 1:Code-Review +1
View Change
3 comments:
Commit Message:
Patch Set #1, Line 7: ich7_run_opcode() fail early on transact error
Bail early on flash cycle errors in ich7_run_opcode()
Patch Set #1, Line 9:
This patch is adapted from the ChromiumOS fork. While we no longer ship
and support the devices:
nit: IMHO, the last sentence parses a bit strange. I'd say:
This patch is adapted from the ChromiumOS fork, and was used on the following, now-obsolete devices:
Patch Set #1, Line 12: ,
I'd omit the punctuation on the elements of this list
To view, visit change 46325. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I93198cb8536705e9b71b7fbe43a20e151c2a72a8
Gerrit-Change-Number: 46325
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Stefan Reinauer <reinauer@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 13 Oct 2020 11:07:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment