Attention is currently required from: Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71975 )
Change subject: flashrom_tester: Check WP range after setting it ......................................................................
Patch Set 7:
(4 comments)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/71975/comment/111f5c46_32ee18cf PS6, Line 207: Range<usize>
Is it possible for multiple ranges to be protected at the same time?
No, although the stuff nikolai is working on might introduce this, it doesnt exist yet.
https://evanbenn.users.x20web.corp.google.com/www/libflashrom-doc/html/group...
https://review.coreboot.org/c/flashrom/+/71975/comment/50ff5b4b_3ddbdb2b PS6, Line 227: \d
`[[:xdigit:]]`
!
lucky that worked in my test?
https://review.coreboot.org/c/flashrom/+/71975/comment/6605ec4d_e7c82de3 PS6, Line 231: range_match.get(1).unwrap().as_str()
You can use `range_match[1]` to be more concise.
Done
File util/flashrom_tester/flashrom/src/lib.rs:
https://review.coreboot.org/c/flashrom/+/71975/comment/7b6dc926_5e088838 PS6, Line 123: range
"range of addresses that are protected" seems a little clearer.
Done