Attention is currently required from: Peter Marheine.

View Change

4 comments:

• File util/flashrom_tester/flashrom/src/cmd.rs:

  • Patch Set #6, Line 207: Range<usize>

    Is it possible for multiple ranges to be protected at the same time?

    No, although the stuff nikolai is working on might introduce this, it doesnt exist yet.

    https://evanbenn.users.x20web.corp.google.com/www/libflashrom-doc/html/group__flashrom-wp.html#gaa264cece050671cb0ea4198ad6b81970

  • Patch Set #6, Line 227: \d

    `[[:xdigit:]]`

    !

    lucky that worked in my test?

  • Patch Set #6, Line 231: range_match.get(1).unwrap().as_str()

    You can use `range_match[1]` to be more concise.

    Done

• File util/flashrom_tester/flashrom/src/lib.rs:

  • Patch Set #6, Line 123: range

    "range of addresses that are protected" seems a little clearer.

    Done

To view, visit change 71975. To unsubscribe, or for help writing mail filters, visit settings.