Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 )
Change subject: cli_classic: include a fallback inplementation of getopt ......................................................................
Patch Set 7: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/73102/comment/affcc7fd_c077df37 PS7, Line 12: DJGPP/DOS I think inline is better:
DJGPP/DOS may not provide getopt ...
File cli_getopt.c:
https://review.coreboot.org/c/flashrom/+/73102/comment/0ed28a52_4fee9186 PS7, Line 2: * This file is part of the flashrom project. It comes originally from the musl : * libc project and is licensed under the terms of the MIT license. I don't know about licences in details, I hope it's all fine! :)
https://review.coreboot.org/c/flashrom/+/73102/comment/03ccfc62_04ec51e6 PS7, Line 254: : : Let's keep 1 line in between functions (in this file, some has 2-3 empty lines break)
File include/cli_classic.h:
https://review.coreboot.org/c/flashrom/+/73102/comment/c7a30d97_0281a6c1 PS7, Line 1: # We need to add a license header? we still have them...
https://review.coreboot.org/c/flashrom/+/73102/comment/1caa3370_b578e580 PS7, Line 3: 1 line break is enough I think
File meson.build:
https://review.coreboot.org/c/flashrom/+/73102/comment/55ca427a_852fbec8 PS7, Line 637: cli_srcs = files( : 'cli_classic.c', : 'cli_common.c', : 'cli_output.c' : ) : : if not cc.has_function('getopt_long') : cli_srcs += files('cli_getopt.c') : endif : : This block should be intended to the right it seems? it is inside if condition?