Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons.

Patch set 7:Code-Review +1

View Change

6 comments:

• Commit Message:

  • Patch Set #7, Line 12: DJGPP/DOS

    I think inline is better:

    DJGPP/DOS may not provide getopt ...

• File cli_getopt.c:

  • Patch Set #7, Line 2:

     * This file is part of the flashrom project. It comes originally from the musl
     * libc project and is licensed under the terms of the MIT license.
    

    I don't know about licences in details, I hope it's all fine! :)

  • Patch Set #7, Line 254:

    Let's keep 1 line in between functions (in this file, some has 2-3 empty lines break)

• File include/cli_classic.h:

  • Patch Set #7, Line 1: #

    We need to add a license header? we still have them...

  • Patch Set #7, Line 3:

    1 line break is enough I think

• File meson.build:

  • Patch Set #7, Line 637:

    cli_srcs = files(
      'cli_classic.c',
      'cli_common.c',
      'cli_output.c'
    )
    
    if not cc.has_function('getopt_long')
      cli_srcs += files('cli_getopt.c')
    endif
    
    
    

    This block should be intended to the right it seems? it is inside if condition?

To view, visit change 73102. To unsubscribe, or for help writing mail filters, visit settings.