Attention is currently required from: ChrisEric1 CECL, Nicholas Chin.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB 3 XHCI flashing ......................................................................
Patch Set 12:
(11 comments)
Patchset:
PS12: Great work. Nearly complete 🎉
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/474557df_49be5a42 PS12, Line 69: struct pci_dev *dev This is still wrong. it must be ``` struct vl805_spi_data *data = (struct vl805_spi_data *)flash->mst->spi.data; ```
https://review.coreboot.org/c/flashrom/+/72057/comment/8e7dbf05_6ed50e54 PS12, Line 76: dev And here ``` data->dev ```
https://review.coreboot.org/c/flashrom/+/72057/comment/e71ed9b8_31f81b9d PS12, Line 85: dev `data->dev`
https://review.coreboot.org/c/flashrom/+/72057/comment/2daeed4d_3dee60c5 PS12, Line 86: dev `data->dev`
https://review.coreboot.org/c/flashrom/+/72057/comment/14b00d98_395b051a PS12, Line 90: dev `data->dev`
https://review.coreboot.org/c/flashrom/+/72057/comment/3c943c81_f5412440 PS12, Line 94: dev `data->dev`
https://review.coreboot.org/c/flashrom/+/72057/comment/fdb45233_b997c24b PS12, Line 95: dev `data->dev`
https://review.coreboot.org/c/flashrom/+/72057/comment/7fd61094_ea8832f4 PS12, Line 102: dev `data->dev`
https://review.coreboot.org/c/flashrom/+/72057/comment/635ad350_af1b28d1 PS12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data)); Please move the allocation of vl805_spi_data below ``` pcidev_init(...); if(!dev) return 1; ```
https://review.coreboot.org/c/flashrom/+/72057/comment/993180ae_11e5cd98 PS12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data)); Please tests if the allocation was successful. ``` truct vl805_spi_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("cannot allocate memory for vl805_data\n"); return 1; } ```