Attention is currently required from: ChrisEric1 CECL, Nicholas Chin.

View Change

11 comments:

• Patchset:

  • Patch Set #12:

    Great work. Nearly complete 🎉

• File vl805.c:

  • Patch Set #12, Line 69: struct pci_dev *dev

    This is still wrong. it must be
    ```
    struct vl805_spi_data *data = (struct vl805_spi_data *)flash->mst->spi.data;
    ```

  • Patch Set #12, Line 76: dev

    And here
    ```
    data->dev
    ```

  • Patch Set #12, Line 85: dev

    `data->dev`

  • Patch Set #12, Line 86: dev

    `data->dev`

  • Patch Set #12, Line 90: dev

    `data->dev`

  • Patch Set #12, Line 94: dev

    `data->dev`

  • Patch Set #12, Line 95: dev

    `data->dev`

  • Patch Set #12, Line 102: dev

    `data->dev`

  • Patch Set #12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data));

    Please move the allocation of vl805_spi_data below
    ```
    pcidev_init(...);
    if(!dev)
      return 1;
    ```

  • Patch Set #12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data));

    Please tests if the allocation was successful.
    ```
    truct vl805_spi_data *data = calloc(1, sizeof(*data));
    if (!data) {
    	msg_perr("cannot allocate memory for vl805_data\n");
    	return 1;
    }
    ```

To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.