Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41779 )
Change subject: lspcon_i2c_spi.c: Add debug message that shows the active block ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/41779/2/lspcon_i2c_spi.c File lspcon_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/41779/2/lspcon_i2c_spi.c@482 PS2, Line 482: ret |= lspcon_i2c_spi_write_register(fd, 0x8e, 0x00); : ret |= lspcon_i2c_spi_write_register(fd, 0x8f, 0x00);
Put a comment above, `/* Set rom addr to beginning. */` […]
Why is this being done?
https://review.coreboot.org/c/flashrom/+/41779/2/lspcon_i2c_spi.c@487 PS2, Line 487: 0x0e
Perhaps this should be a #define or have a inline comment /* .. […]
It's just the register being read. There probably should be more generic i2c register read/write functions that don't hard-code the i2c address for cases like this.