2 comments:

File lspcon_i2c_spi.c:
- Patch Set #2, Line 482:
```
	ret |= lspcon_i2c_spi_write_register(fd, 0x8e, 0x00);
	ret |= lspcon_i2c_spi_write_register(fd, 0x8f, 0x00);
```
  Put a comment above, `/* Set rom addr to beginning. */` […]
  Why is this being done?
- Patch Set #2, Line 487: 0x0e
  Perhaps this should be a #define or have a inline comment /* .. […]
  It's just the register being read. There probably should be more generic i2c register read/write functions that don't hard-code the i2c address for cases like this.

To view, visit change 41779. To unsubscribe, or for help writing mail filters, visit settings.