Konstantin Grudnev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34496 )
Change subject: Add support for M95M02-A125 ......................................................................
Patch Set 2:
(8 comments)
fixed
https://review.coreboot.org/c/flashrom/+/34496/1/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/34496/1/flashchips.h@856 PS1, Line 856: 0x00
If we know it's supposed to be 0x00, why not check it?
Done
https://review.coreboot.org/c/flashrom/+/34496/1/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34496/1/flashchips.c@14114 PS1, Line 14114: .feature_bits = FEATURE_WRSR_WREN,
FEATURE_NO_ERASE and FEATURE_ERASED_ZERO?
Done
https://review.coreboot.org/c/flashrom/+/34496/1/flashchips.c@14121 PS1, Line 14121: .eraseblocks = { { 256 * 1024, 1 } },
what do you mean by declaring { 256, 1 } ? I tried it and it tries to erase only first 256 bytes, al […]
Done
https://review.coreboot.org/c/flashrom/+/34496/1/spi25.c File spi25.c:
PS1:
(spi)25 != 95, please don't hesitate to start a new file. Or maybe […]
Done
https://review.coreboot.org/c/flashrom/+/34496/1/spi25.c@269 PS1, Line 269: /* ST_M95_RDID_OUTSIZE depends on size of the flash and
Please start multi-line comments with /* on a separate line. However this […]
Done
https://review.coreboot.org/c/flashrom/+/34496/1/spi25.c@272 PS1, Line 272: static const unsigned char cmd[ST_M95_RDID_OUTSIZE] = {ST_M95_RDID};
spaces around ST_M95_RDID, please
Done
https://review.coreboot.org/c/flashrom/+/34496/1/spi25.c@282 PS1, Line 282: "L 0x%02x, M 0x%02x, H 0x%02x]\n",
Please align output with the existing probing functions. […]
Done
https://review.coreboot.org/c/flashrom/+/34496/1/spi25.c@635 PS1, Line 635: }
Alternatively, allocate `blocklen` bytes and let spi_write_chunked() take […]
Done